4799 - failing test sign transactions #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luu-alex
requested review from
spacesailor24,
avkos,
jdevcs,
nazarhussain and
nikoulai
nazarhussain
approved these changes
May 25, 2022
jdevcs
added
1.x
jdevcs
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4799
A summary of the investigation was created here in 1.x issues: #5071.
signing transactions in 4.x looks fine, so tests uncommented and some expected results were changed
For the rlp issue, when 1.x isn't tested using BN the rawtransaction and transactionhash is the same in both 1.x and 4.x